[Issue #332] Delete certifi runtime hook #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LincolnPuzey
requested review from
a team and
rokm
and removed request for
a team
|
@rokm @bwoodsend What sort of news entry does this require? |
|
Also I think I need to remove the reference to this hook in |
Just an update one.
Yes, you're right. |
This hook is being deleted because it is not required for certifi to function and it introduces inconsistent behavior between frozen/unfrozen code.
LincolnPuzey
force-pushed
the
issue-332
branch
from
4857bb7
to
11255a9
Compare
bwoodsend
approved these changes
Oct 25, 2021
|
Thanks @bwoodsend ! |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook is being deleted because it is not required for certifi to function and it introduces inconsistent behavior between frozen/unfrozen code.
See issue #332 for details.