Update hook-passlib.py #39
Conversation
Without `configparser`, importing passlib yields the following traceback:
```
import passlib.apache
File "lib/python3.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 493, in exec_module
exec(bytecode, module.__dict__)
File "passlib/apache.py", line 14, in <module>
File "lib/python3.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 493, in exec_module
exec(bytecode, module.__dict__)
File "passlib/context.py", line 21, in <module>
File "passlib/utils/compat/__init__.py", line 417, in __getattr__
File "passlib/utils/compat/__init__.py", line 379, in _import_object
ModuleNotFoundError: No module named 'configparser'
```
mhils
requested review from
a team and
bwoodsend
and removed request for
a team
Yes please 😄. |
There was a problem hiding this comment.
This needs a changelog entry. See the news README.
Optionally, it would be good if we could have a test for this too...
|
Would you like me to open separate PRs for each hook or update everything here? There will definitely be some merge conflicts in the former case due to tests and requirements being added at the same location. |
|
Definitely separate PRs please. |
|
@amifunny Go for it. |
@bwoodsend You want me to merge? I don't have commit rights. |
|
@bwoodsend I haven't given @amifunny write permission here yet. However, I suggest you get him to review PRs first, before you do, so he can practice. |
These parts have been upstreamed: - pyinstaller/pyinstaller-hooks-contrib#39 - pyinstaller/pyinstaller-hooks-contrib#40 - pyinstaller/pyinstaller-hooks-contrib#41
Thank you @Legorooj and other for setting this repo up here! 😃 We've been maintaining some custom third-party hooks for @mitmproxy for a while, which I'd be happy to contribute here.
To start things off, passlib is missing a hidden import. Without
configparser, importing passlib yields the following traceback: