Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook pyshark #449

Merged
merged 8 commits into from
Jun 16, 2022
Merged

Add hook pyshark #449

merged 8 commits into from
Jun 16, 2022

Conversation

LpCodes
Copy link
Contributor

@LpCodes LpCodes commented Jun 14, 2022

Have made changes as suggest kindly review

Copy link
Member

@rokm rokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments. Also, make your changes to this PR instead of opening a new one. Thanks!

news/445.new.rst Outdated Show resolved Hide resolved
requirements-test.txt Outdated Show resolved Hide resolved
src/_pyinstaller_hooks_contrib/tests/test_libraries.py Outdated Show resolved Hide resolved
@LpCodes LpCodes requested a review from rokm June 15, 2022 05:58
news/445.new.rst Outdated Show resolved Hide resolved
requirements-test.txt Outdated Show resolved Hide resolved
src/_pyinstaller_hooks_contrib/tests/test_libraries.py Outdated Show resolved Hide resolved
@LpCodes LpCodes requested a review from rokm June 16, 2022 05:17
@bwoodsend bwoodsend merged commit 6b02be2 into pyinstaller:master Jun 16, 2022
@bwoodsend
Copy link
Member

Thanks @LpCodes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants