Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: cv2: collect Qt fonts data and plugins from linux PyPI wheels #453

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

rokm
Copy link
Member

@rokm rokm commented Jun 27, 2022

In linux PyPI opencv-python wheels, the cv2 extension is linked against Qt, and the wheel bundles a basic subset of Qt shared libraries, plugins, and font files. This is not the case on other OSes (presumably native UI APIs are used by the OpenCV HighGUI
module), nor in the headless PyPI wheels (opencv-python-headless).

The bundled Qt shared libraries should be picked up automatically due to binary dependency analysis, but we need to collect plugins and font files from the qt subdirectory.

Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need a news entry for this?

rokm added 2 commits June 27, 2022 21:01
In linux PyPI opencv-python wheels, the cv2 extension is linked
against Qt, and the wheel bundles a basic subset of Qt shared
libraries, plugins, and font files. This is not the case on other
OSes (presumably native UI APIs are used by the OpenCV HighGUI
module), nor in the headless PyPI wheels (opencv-python-headless).

The bundled Qt shared libraries should be picked up automatically
due to binary dependency analysis, but we need to collect plugins
and font files from the qt subdirectory.
@rokm
Copy link
Member Author

rokm commented Jun 27, 2022

Do we not need a news entry for this?

We do.

@rokm rokm merged commit 0faf4a0 into pyinstaller:master Jun 27, 2022
@rokm rokm deleted the hooks-cv2-linux-qt branch June 27, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants