Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyshark hook to be compatible with versions >=0.5. #477

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

bwoodsend
Copy link
Member

@bwoodsend bwoodsend commented Aug 16, 2022

Let's put pyshark out of its misery...

@bwoodsend
Copy link
Member Author

Hmm, v0.5.0 fails because pyshark.capture is a namespace package. v0.5.2 puts the __init__.py file back in so we could skip over this one but PyInstaller should be able to handle namespace packages?

@bwoodsend
Copy link
Member Author

bwoodsend commented Aug 16, 2022

Ahh.

> unzip -l ~/Downloads/pyshark-0.5-py3-none-any.whl 
Archive:  /home/brenainn/Downloads/pyshark-0.5-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
      716  2022-06-27 10:18   pyshark/__init__.py
      373  2022-06-28 13:02   pyshark/cache.py
      471  2022-06-28 07:13   pyshark/config.ini
      517  2022-07-08 16:37   pyshark/config.py
     2594  2022-07-04 11:58   pyshark/ek_field_mapping.py
      899  2022-07-08 16:38   pyshark-0.5.dist-info/METADATA
       92  2022-07-08 16:38   pyshark-0.5.dist-info/WHEEL
        8  2022-07-08 16:38   pyshark-0.5.dist-info/top_level.txt
      666  2022-07-08 16:38   pyshark-0.5.dist-info/RECORD
---------                     -------
     6336                     9 files

Not our bug! Grins smuggly in the knowledge that namespace packages which I've said shouldn't exist have gone and made a mess on someone else

@rokm
Copy link
Member

rokm commented Aug 16, 2022

Yeah, 5.0 has bogus wheels...

@bwoodsend bwoodsend merged commit daf7a23 into pyinstaller:master Aug 16, 2022
@bwoodsend bwoodsend deleted the pyshark branch August 16, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants