Add hooks for skimage.feature and skimage.graph #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoodsend
reviewed
Sep 29, 2020
A battery of tests that individually import each of skimage submodules. The list of tests is based on submodules available in the latest releases (0.16.x and 0.17.x).
Needed for hidden import of skimage.feature._orb_descriptor_positions.
Needed for hidden import of skimage.graph.heap.
bwoodsend
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic import test for
skimagebased on the issues encountered while solving pyinstaller/pyinstaller#5197.Based on the test failures under scikit-image 0.17.2, we need additional hooks for
skimage.featureandskimage.graphto deal with the missing (sub)modules.