Add hooks for compliance_checker and its dependencies #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify hidden imports required by the cftime._cftime, which is a cython extension.
Around the time netCDF4 v1.4.0 was released, the netcdftime package was renamed to cftime, so we need to adjust the hidden imports specified by the hook.
Ensure that the XML files from cf_units/etc sub-directory are collected.
rokm
force-pushed
the
hook-compliance_checker
branch
2 times, most recently
from
3f25462
to
716528a
Compare
And a test that runs the validation against one of the test data files shipped with the package.
rokm
force-pushed
the
hook-compliance_checker
branch
from
716528a
to
ac1a771
Compare
compliance_checker depends on cf_units, and the latter provides wheels only for macOS and linux, and for python >= 3.8. So add corresponding constraints to requirements-test-libraries.txt
rokm
force-pushed
the
hook-compliance_checker
branch
from
ac1a771
to
1311472
Compare
bwoodsend
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #517.