hooks: update hooks for scikit-learn #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A battery of tests that individually import each of sklearn submodules. The list of tests is based on submodules available in the latest release (0.23.x), but it has been unchanged since 0.21. Incidentally, scikit-learn 0.21 supports Python 3.5-3.7, scikit-learn 0.22 supports Python 3.5-3.8, while the latest versions require Python 3.6 or newer. Therefore, the test supports scikit-learn >= 0.21, and the same versions will be targeted by our hooks.
Add hidden imports required for basic submodule import tests to pass under scikit-learn 0.22.x with python 3.8.5 on linux.
In scikit-learn v.0.23, the sklearn.cluster contains a hidden dependency on threadpoolctl.
rokm
requested review from
a team and
bwoodsend
and removed request for
a team
|
The corresponding oneshot test: https://github.com/rokm/pyinstaller-hooks-contrib/actions/runs/285067272 |
Cleaned up hook-sklearn.metrics.cluster.py. It is still required by scikit-learn 0.21, but sklearn.utils.sparsetools hidden module has been removed during transition from 0.20 to 0.21. The hook-sklearn.mixture.py is redundant, as all of its required hidden modules are covered by hooks for other top-level modules, for example the hook for sklearn.neighbors. The latter now contains hidden import names that are compatible with both 0.21 and 0.22+.
|
Hmm, I could do with adding a if installing dependencies fails: skip to that CI to catch unavailable Python version/package version combos. |
Legorooj
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic import test for each scikit-learn (sklearn) submodule, and update hooks so that all tests pass with scikit-learn v.0.21, v.0.22, and v.0.23.