Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: add hook for metpy #60

Merged
merged 2 commits into from
Sep 10, 2021
Merged

hooks: add hook for metpy #60

merged 2 commits into from
Sep 10, 2021

Conversation

rokm
Copy link
Member

@rokm rokm commented Oct 26, 2020

Partially fixes pyinstaller/pyinstaller#5247 (missing metadata and data files). Full fix requires pyinstaller/pyinstaller#5284, which is also required for the added test to pass.

@rokm
Copy link
Member Author

rokm commented Apr 27, 2021

This should be ready now. I was trying to pin latest version of MetPy (1.0), but it turns out they switched from pkg_resources to importlib.resources / importlib_resources, and importlib_resources does not play nicely with PyInstaller...

@rokm rokm marked this pull request as ready for review April 27, 2021 19:44
@rokm rokm requested review from a team and Legorooj and removed request for a team April 27, 2021 19:44
@Legorooj Legorooj force-pushed the master branch 10 times, most recently from 8003b05 to df3371d Compare June 26, 2021 05:59
Try importing metpy.plots instead of just metpy, as that triggers
the search for colortables data, and thus uncovers more issues.
Basic hook that collects metadata and data files.
@rokm
Copy link
Member Author

rokm commented Sep 10, 2021

Oneshot test: https://github.com/rokm/pyinstaller-hooks-contrib/actions/runs/1221186892

(the two failures on python 3.9 are due to lack of wheels for pinned requirement versions).

@rokm rokm requested a review from bwoodsend September 10, 2021 12:42
@rokm
Copy link
Member Author

rokm commented Sep 10, 2021

We now support both 0.12.x series that uses pkg_resources and 1.x series that switched to importlib.resources / importlib_resources.

@rokm rokm merged commit 629cc75 into pyinstaller:master Sep 10, 2021
@rokm rokm deleted the hook-metpy branch September 10, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources.DistributionNotFound: The 'metpy' distribution was not found and is required by the application
2 participants