hooks: Add hook for ijson #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steelsmasher
requested review from
a team and
bwoodsend
and removed request for
a team
bwoodsend
requested changes
Oct 31, 2020
There was a problem hiding this comment.
This needs a news entry (something like Add hook for ijson which has dynamically loaded backends.) but other than that you're good to go. Don't worry about the failing tests - they're failing due to something else...
bwoodsend
approved these changes
Oct 31, 2020
Legorooj
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook for the ijson package at: https://github.com/ICRAR/ijson
Ijson is an iterative JSON parser which is useful for reading very large json files. The backend modules necessary to run ijson are dynamically loaded hence the need for this hook.