Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: Add hook for lxml #66

Merged
merged 2 commits into from
Nov 4, 2020
Merged

hooks: Add hook for lxml #66

merged 2 commits into from
Nov 4, 2020

Conversation

doudz
Copy link
Contributor

@doudz doudz commented Nov 4, 2020 •
edited
Loading

lxml has hiddenimports and is not fully embedded when adding it to hiddenimports

hiddenimports = ['lxml'] is not enough
see pyinstaller/pyinstaller#5306

@doudz doudz requested review from a team and bwoodsend and removed request for a team November 4, 2020 08:01
@bwoodsend
Copy link
Member

Perfect thanks. We aim to release these monthly so in a few weeks you'll be able to

pip install -U pyinstaller-hooks-contrib

But until then use

pip install -U https://github.com/pyinstaller/pyinstaller-hooks-contrib/archive/master.zip

@bwoodsend bwoodsend merged commit 2b9b5d1 into pyinstaller:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoodsend bwoodsend bwoodsend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doudz @bwoodsend