hooks: skimage.feature: collect file with ORB descriptor positions #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the basic scikit-learn and scikit-image import tests only in onedir mode.
Have the hook for `skimage.feature` collect the `orb_descriptor_positions.txt` file, which is required by `skimage.feature.ORB`. Add a basic test for ORB detector and descriptor extractor.
bwoodsend
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the hook for
skimage.featurecollect theorb_descriptor_positions.txtfile, which is required byskimage.feature.ORB. Closes pyinstaller/pyinstaller#8176.Add a basic test for ORB detector and descriptor extractor.
This PR also extracts the tests for scikit-image and scikit-learn from
test_libraries.pyinto separate test files, as a first step of planned refactoring of that huge test file into smaller files based on a specific package or thematically similar packages.