-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default enabled sentry integrations dynamically to hidden imports #71
Add default enabled sentry integrations dynamically to hidden imports #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've dealt with my review comments could you launch our CI tester? From the root of your copy of this repo, check your in your sentry_django_integration
branch, then run:
python scripts\cloud-test.py --os=windows --os=ubuntu --py=3.6,3.8 --browser sentry-sdk==0.15.1, sentry-sdk==0.19.3
You'll need to create a github authentication token if you don't already have one because github have stopped accepting username and password.
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-sentry_sdk.py
Outdated
Show resolved
Hide resolved
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-sentry_sdk.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Brénainn Woodsend <30940778+bwoodsend@users.noreply.github.com>
@bwoodsend How should I handle the trailing whitespace problem as reported by the linter? Or does python inside |
Linter is complaining about the extra whitespace at the end of the line 30 (after "integrations"). |
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-sentry_sdk.py
Outdated
Show resolved
Hide resolved
Looks good.
Can you go ahead and do this now? If it passes then we should be ready to merge this. |
Perfect - thanks for your contribution! |
Sentry added in PR getsentry/sentry-python#625 by default enabled integrations. We need to add them to the hidden imports to be able to launch a application with sentry.
I added the hasattr check for backwards compatibility