Fix up sspilib credential ordering #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
approved these changes
Mar 6, 2024
github-actions bot
pushed a commit
to wxx9248/Pickle-Rush
that referenced
this pull request
Mar 11, 2024
…4.3 (#91) Bumps [pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib) from 2024.2 to 2024.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's releases</a>.</em></p> <blockquote> <h2>2024.3</h2> <p>Please see the <a href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a> for more details</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's changelog</a>.</em></p> <blockquote> <h2>2024.3 (2024-03-09)</h2> <p>Updated hooks</p> <pre><code> * Update ``torch`` hook to add support for MKL-enabled ``torch`` builds on Windows (e.g., the nightly ``2.3.0.dev20240308+cpu`` build). The hook now attempts to discover and collect DLLs from MKL and its dependencies (``mkl``, ``tbb``, ``intel-openmp``). (`[#712](pyinstaller/pyinstaller-hooks-contrib#712) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/712>`_) </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/8e0ea4d2e9d18fbc5355f5853ae40e13fb154a78"><code>8e0ea4d</code></a> Release v2024.3</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/248cc8ad46f5319599356ee531c730128a3b9a24"><code>248cc8a</code></a> hooks: torch: add support for MKL-enabled torch builds</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/409bd3ce064b8834bec13d20d8c0e4f2367e455d"><code>409bd3c</code></a> Fix up sspilib credential ordering</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/5a553ff210635443d41ed5dab97f47196fcfa8e3"><code>5a553ff</code></a> Scheduled weekly dependency update for week 09 (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/711">#711</a>)</li> <li>See full diff in <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2024.2...2024.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change for
sspilibjborean93/sspilib#13 has changed the ordering of the arguments now thatcredentialwas deemed to be mandatory. While this was a breaking change this was the only example I found using GitHub search that showed an instance where the change would break. This PR uses kwargs to ensure it will work with the old and new syntax during the transition.