Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: add hook for schwifty #742

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

rokm
Copy link
Member

@rokm rokm commented May 9, 2024

Add hook for schwfity that collects the data files (the JSON files in bank_registry) and package's metadata.

@mdomke
Copy link

mdomke commented May 9, 2024

It seems as if the tests fail, because schwifty does not include typing-extensions as dependency. This must have slipped through my own tests, because the library probably installed by some test-dependency. I will create a new release that fixe this problem.

@rokm
Copy link
Member Author

rokm commented May 9, 2024

It seems as if the tests fail, because schwifty does not include typing-extensions as dependency. This must have slipped through my own tests, because the library probably installed by some test-dependency. I will create a new release that fixe this problem.

Indeed - I've opened mdomke/schwifty#203.

@mdomke
Copy link

mdomke commented May 9, 2024

Please update to 2024.05.2 where the issue has been fixed and typing-extensions is explicitly required again for Python < 3.11.

Add hook for `schwfity` that collects the data files (the JSON
files in `bank_registry`) and package's metadata.
@rokm rokm merged commit fe2deb3 into pyinstaller:master May 9, 2024
14 checks passed
@rokm rokm deleted the hook-schwifty branch May 9, 2024 22:31
github-actions bot pushed a commit to wxx9248/Pickle-Rush that referenced this pull request May 10, 2024
…4.6 (#97)

Bumps
[pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib)
from 2024.5 to 2024.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's
releases</a>.</em></p>
<blockquote>
<h2>2024.6</h2>
<p>Please see the <a
href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a>
for more details</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's
changelog</a>.</em></p>
<blockquote>
<h2>2024.6 (2024-05-10)</h2>
<p>New hooks</p>
<pre><code>
* Add hook for ``schwifty``. Requires ``schwifty &gt;= 2024.5.1`` due to
issues with data search path in earlier versions.
(`[#742](pyinstaller/pyinstaller-hooks-contrib#742)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/742&gt;`_)
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/d8f2abdba7787b82f4a2969c871ce4636834d215"><code>d8f2abd</code></a>
Release v2024.6</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/fe2deb34454e5f714fc6cdb0ea603599c48b9a7f"><code>fe2deb3</code></a>
hooks: add hook for schwifty</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/277ff2c74c2e33ecf15686e7035dd2b5a8e5de04"><code>277ff2c</code></a>
Scheduled weekly dependency update for week 18 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/740">#740</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/3ce4ae66ccf5996aef779be9223d03471611b868"><code>3ce4ae6</code></a>
Scheduled weekly dependency update for week 17 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/738">#738</a>)</li>
<li>See full diff in <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2024.5...2024.6">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyinstaller-hooks-contrib&package-manager=pip&previous-version=2024.5&new-version=2024.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants