-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX 12 tests are sometime timing out #1357
Comments
Did we agree on what to do in the mean time with open PRs? My gut feeling is that as long as other tests pass it's probably fine-ish. |
We didn't agree. The default position should be "don't merge things that don't pass tests". Your proposal for an exception in this case is not unreasonable, but I have a deep discomfort with the idea 😝 |
E.g. in #1356 and #1349, although not in #1352.
Here's a dump of the tests section of the log from #1356:
The text was updated successfully, but these errors were encountered: