Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on comments in coveralls #1482

Closed
DanielNoord opened this issue Mar 21, 2022 · 3 comments
Closed

Turn on comments in coveralls #1482

DanielNoord opened this issue Mar 21, 2022 · 3 comments
Assignees
@Pierre-Sassoulas
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Milestone
2.12.0

Comments

@DanielNoord
Copy link
Collaborator

Could it be that the coverage comment from coveralls is not turned on? Would be helpful if we could turn it on for the project!
@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Mar 21, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Mar 21, 2022
@Pierre-Sassoulas
Copy link
Member

Nice catch it should be fixed, let's close when we see the first one.

@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Mar 21, 2022
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Could you turn on the "advanced" or "expanded" version? Or whatever they call it. That way we also get the table with changed files.

@Pierre-Sassoulas
Copy link
Member

It worked on #1189, I changed to advanced :) I tried to forbid coverage decrease of more than 0.05% too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pierre-Sassoulas Pierre-Sassoulas

Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
2 participants
@Pierre-Sassoulas @DanielNoord