Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why the spellchecking checks are slow #2249

Open
PCManticore opened this issue Jul 4, 2018 · 3 comments
Open

Investigate why the spellchecking checks are slow #2249

PCManticore opened this issue Jul 4, 2018 · 3 comments
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning performance

Comments

@PCManticore
Copy link
Contributor

pylint-dev/astroid#579 (comment) this comment mentioned that disabling the spellchecking checks improvement the runtime of pylint from half an hour to ~10 minutes, which suggests that something might be completely off with the spellchecking. We should investigate to see why is that, and if we can find that these are hurting the performance, we should either disable the spellchecking by default (as we do for the Py3k porting checks), or we should move them to an extension, so that they can be enabled explicitly by the user.

@svmhdvn
Copy link

svmhdvn commented Oct 3, 2018

I can take a closer look at this, we're running into pylint performance issues as well.

@robin-wayve
Copy link
Contributor

I didn't know these checks existed and have never actually seen them fail a check (although I'm almost certain our codebase has plenty of spelling errors in comments and docstrings).

Maybe pylint could consider dropping these checks in a future major version and recommending an alternative like codespell instead?

@Pierre-Sassoulas
Copy link
Member

I think python-enchant need to be installed for those checks to run.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning and removed task labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants