Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add a check for raise foo from bar #3687

Closed
cool-RR opened this issue Jun 13, 2020 · 2 comments · Fixed by #3695
Closed

Feature request: Add a check for raise foo from bar #3687

cool-RR opened this issue Jun 13, 2020 · 2 comments · Fixed by #3695
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors Proposal 📨

Comments

@cool-RR
Copy link
Contributor

cool-RR commented Jun 13, 2020

I recently went over Matplotlib, Pandas and NumPy, fixing a small mistake in the way that Python 3's exception chaining is used. I've done it here too (#3681 )

I suggested to @Pierre-Sassoulas that this should be a PyLint rule.

@jdufresne wrote a flake8 plugin that does this, plus catches two other raise-related issues that I like and could be added as well.

What do you think?

@Pierre-Sassoulas Pierre-Sassoulas added Proposal 📨 Enhancement ✨ Improvement to a component labels Jun 14, 2020
@PCManticore PCManticore added the Good first issue Friendly and approachable by new contributors label Jun 16, 2020
@PCManticore
Copy link
Contributor

Sounds like a good idea, thanks for the suggestion!

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 16, 2020

I'm working on implementing this feature.

@Pierre-Sassoulas Pierre-Sassoulas linked a pull request Jun 16, 2020 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors Proposal 📨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants