-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require enums to be named IN_ALL_CAPS #3834
Comments
@socketpair thanks for the suggestion. |
Personally I write all my enums in UPPER_CASE and I think the Enums should not be changed, so its always a constant, and I think pep8 already says constants should be in uppercase. This is my interpretation though, I think we can wait for the ongoing discussion on Issue40721 to be resolved before rushing to implement something. |
I think we should check for this for the same reasons that Guido gives. I'd argue that PEP-8 does cover the them because they're constants, but I'm happy to wait for Issue40721 to come to some consensus. |
Totally agree with you. Let's wait for Issue40721 for now. |
I put the label blocked just to ease the triage. |
@hippo91 Issue40721 is closed (resolved) now. |
@socketpair thanks! I removed the blocked label. |
Hello! I would like to try to solve this issue. |
@Hee-San Just make a pull request ! You are welcome. |
https://bugs.python.org/issue40721
For Python code at least, Guido has proclaimed:
https://mail.python.org/pipermail/python-ideas/2016-September/042340.html
The text was updated successfully, but these errors were encountered: