Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int32 or Int64 for discrete? #3475

Closed
lucianopaz opened this issue May 10, 2019 · 4 comments · Fixed by #7114
Closed

Int32 or Int64 for discrete? #3475

lucianopaz opened this issue May 10, 2019 · 4 comments · Fixed by #7114

Comments

@lucianopaz
Copy link
Contributor

Through a recent discourse thread I found that Discrete allows int16 or int64 dtypes. Given what we had done for parameters regarding #2366 (we set int16 if floatX is float32 and int32 if floatX is float64), should we change Discrete to work with int16 and int32? What do we do with int64's?
@ricardoV94
Copy link
Member

Related to #4553

@ferrine
Copy link
Member

ferrine commented Feb 3, 2022

Every dtype makes sense, can we specify it with dtype arg? I remember struggling with that and fixed in v3, but not v4

@ricardoV94 ricardoV94 reopened this Mar 17, 2022
@ricardoV94
Copy link
Member

Let's not coerce dtype of integer parameters then

@ricardoV94
Copy link
Member

Should be closed by #7114

@ricardoV94 ricardoV94 mentioned this issue Feb 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove intX and floatX from distributions aerubanov/pymc3
3 participants
@lucianopaz @ferrine @ricardoV94