Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theano dependency is pinned in 4 places #4320

Closed
twiecki opened this issue Dec 10, 2020 · 2 comments · Fixed by #4322
Closed

Theano dependency is pinned in 4 places #4320

twiecki opened this issue Dec 10, 2020 · 2 comments · Fixed by #4322
Assignees

Comments

@twiecki
Copy link
Member

twiecki commented Dec 10, 2020

A bit unfortunate that we specify the exact version in 4 places now. Do we even need it for the -dev environments? My understanding is that these are just the dependencies in addition to what is in requirements.txt.

@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Dec 10, 2020

In the future, will PyMC release have a minimum theano-pymc/aesara version, or will each PyMC release have one particular theano-pymc release associated with it?

If the latter, then it should probably only be defined in a single place (or there should be checks that the different places it's defined match up). If it's the latter, then in the other three places it's pinned (conda-envs/environment-dev-py36.yml, conda-envs/environment-dev-py37.yml, conda-envs/environment-dev-py38.yml), the pins could be mixed up a bit between them so that different CI jobs run tests with different versions.


I presume the requirements-dev.txt is for people (like @rpgoldman ?) who aren't developing in a conda environment?

In pandas there's a script to generate pip requirements from conda: https://github.com/pandas-dev/pandas/blob/master/scripts/generate_pip_deps_from_conda.py , if you want we could add that to make sure they stay consistent.

@twiecki
Copy link
Member Author

twiecki commented Dec 10, 2020

@MarcoGorelli for the time being we will probably be pretty interlocked with specific theano versions.

I like the idea with generating the pip files from the conda env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants