Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from dill to cloudpickle #4856

Closed
twiecki opened this issue Jul 12, 2021 · 3 comments
Closed

Switch from dill to cloudpickle #4856

twiecki opened this issue Jul 12, 2021 · 3 comments
Assignees

Comments

@twiecki
Copy link
Member

twiecki commented Jul 12, 2021

Other major packages (like airflow) are moving to cloudpickle: apache/airflow#7870

It also seems that cloudpickle as some incompatibilities with dill (as per @michaelosthege) during installation.

@Spaak
Copy link
Member

Spaak commented Jul 12, 2021

So far the default serialization method is pickle, with an optional pickle_backend parameter to pm.sample which can be set to "dill" (required in certain cases, e.g. custom DensityDist). Do we want to keep this as a customizable parameter? Or should we always use cloudpickle? (I think at the very least we want to set cloudpickle to be the default if we make the effort of switching.) I think simply always using cloudpickle (and removing the pickle_backend parameter) would be fine, I don't see any scenario when someone would want to explicitly fall back to using pickle. (But me not seeing it is not enough to conclude there cannot be one ;) )

@twiecki
Copy link
Member Author

twiecki commented Jul 12, 2021

Agree with your logic, seems like we can just use that as a default.

@Spaak
Copy link
Member

Spaak commented Jul 13, 2021

Closed via #4858

@Spaak Spaak closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants