Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize Binomial and Categorical distributions via logit_p #5005

Closed
MarcoGorelli opened this issue Sep 20, 2021 · 5 comments
Closed

Parametrize Binomial and Categorical distributions via logit_p #5005

MarcoGorelli opened this issue Sep 20, 2021 · 5 comments
Labels
beginner friendly enhancements

Comments

@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Sep 20, 2021 •
edited
Loading

Description of your problem

Bernoulli can take logit_p as an argument:

https://github.com/pymc-devs/pymc3/blob/59ce9af97f0b840f992322f33ec8dee203d7d1c0/pymc3/distributions/discrete.py#L334-L339

Could Binomial also take this argument?
@MarcoGorelli MarcoGorelli changed the title Binomial docstring is missing logit_p Give Binomial a logit_p argument Sep 20, 2021
@MarcoGorelli MarcoGorelli changed the title Give Binomial a logit_p argument Could Binomial also take logit_p argument? Sep 20, 2021
@ricardoV94
Copy link
Member

Yes, it could. Also categorical

@ricardoV94 ricardoV94 changed the title Could Binomial also take logit_p argument? Parametrize Binomial and Categorical distributions via logit_p Sep 20, 2021
@neelriyer neelriyer mentioned this issue Sep 23, 2021
Closed
@purna135
Copy link
Member

purna135 commented Mar 2, 2022

I would like to work on this.

@ricardoV94
Copy link
Member

I would like to work on this.

Go ahead :)

@purna135 purna135 mentioned this issue Mar 21, 2022
Merged
@cluhmann
Copy link
Member

cluhmann commented Jul 7, 2022

Anything left here or can this be closed?

@ricardoV94
Copy link
Member

ricardoV94 commented Jul 8, 2022 •
edited
Loading

Anything left here or can this be closed?

Yeah, it's done in #5637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parametrize Binomial and Categorical distributions via logit_p neelriyer/pymc3
4 participants
@ricardoV94 @MarcoGorelli @cluhmann @purna135