Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove value variable information from RV.tag #5033

Closed
ricardoV94 opened this issue Sep 29, 2021 · 2 comments · Fixed by #6281
Closed

Remove value variable information from RV.tag #5033

ricardoV94 opened this issue Sep 29, 2021 · 2 comments · Fixed by #6281
Labels
help wanted v4
Milestone
v4.4.0

Comments

@ricardoV94
Copy link
Member

As we did with test/initial values we should remove the value variable transformation from the .tag if possible. Probably saving it in a model.value_transforms dictionary that can be used directly in aeppl.
@ricardoV94 ricardoV94 added this to the v4.0.0-beta milestone Sep 29, 2021
@ricardoV94
Copy link
Member Author

Same probably applies for observations and scaling information that is added to the tag

@ricardoV94 ricardoV94 mentioned this issue Jan 7, 2022
Merged
@michaelosthege michaelosthege modified the milestones: v4.0.0b2, v4.0.0b3 Jan 7, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.0.0b3, v4.0.0 Feb 3, 2022
@ricardoV94 ricardoV94 mentioned this issue Feb 5, 2022
Closed
@ricardoV94 ricardoV94 modified the milestones: v4.0.0, v4.1.0 Apr 1, 2022
@michaelosthege michaelosthege modified the milestones: v4.1.0, v4.2.0 Jul 2, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.2.0, v4.3.0 Sep 14, 2022
@ricardoV94 ricardoV94 mentioned this issue Oct 20, 2022
Closed
@ricardoV94
Copy link
Member Author

And ultimately to value variables themselves

@ricardoV94 ricardoV94 changed the title Remove transformation information from .tag Remove value variable information from RV.tag Oct 20, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.3.0, v4.4.0 Oct 27, 2022
@ricardoV94 ricardoV94 mentioned this issue Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted v4
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging a pull request may close this issue.

Do not rely on tag information for rv and logp conversions ricardoV94/pymc
2 participants
@michaelosthege @ricardoV94