Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable in _get_scaling is never used #6061

Closed
ricardoV94 opened this issue Aug 25, 2022 · 1 comment · Fixed by #6523
Closed

Variable in _get_scaling is never used #6061

ricardoV94 opened this issue Aug 25, 2022 · 1 comment · Fixed by #6523
Labels
bug maintenance

Comments

@ricardoV94
Copy link
Member

PyCharm tells me this variable is never used:

pymc/pymc/distributions/logprob.py

Line 94 in 4ca3414

coef = 1.0

CC: @ferrine and @chritter
@fonnesbeck
Copy link
Member

Looks like there should be an else block for the code below that assignment, representing begin and end lengths that are neither scalar nor too large.

@ricardoV94 ricardoV94 added the bug label Aug 26, 2022
@ricardoV94 ricardoV94 changed the title Variable in _get_scaling is never used Variable in _get_scaling is never used Aug 26, 2022
@ricardoV94 ricardoV94 mentioned this issue Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace rvs_to_total_sizes mapping by MinibatchRandomVariables ricardoV94/pymc
2 participants
@fonnesbeck @ricardoV94