Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: wrong bound for sigma in docstring of Beta #6295

Closed
Gattocrucco opened this issue Nov 13, 2022 · 3 comments · Fixed by #6344
Closed

DOC: wrong bound for sigma in docstring of Beta #6295

Gattocrucco opened this issue Nov 13, 2022 · 3 comments · Fixed by #6344

Comments

@Gattocrucco
Copy link

Gattocrucco commented Nov 13, 2022

The docstring of Beta says

sigma : tensor_like of float, optional
    Alternative standard deviation (1 < ``sigma`` < sqrt(``mu`` * (1 - ``mu``))).

while it should be 0 < sigma < ....

(Related issue: #5023 says that sigma may be dropped in favor of nu)

Versions and main components

  • PyMC/PyMC3 Version: 4.3.0
  • Aesara/Theano Version: 2.8.7
  • Python Version: 3.10.5
  • Operating system: macos 12.6.1 arm
  • How did you install PyMC/PyMC3: pip
@ricardoV94
Copy link
Member

Seems to have been changed (accidentally?) in #5500

@Gattocrucco Do you want to add a PR to fix it?

About #5023 we would probably add it as an alternative parametrization, instead of deprecating sigma completely because many users probably rely on it. Feel free to take on that PR as well if you are interested :)

@alekracicot
Copy link
Contributor

Is anyone working on this? If not I can do it.

@ricardoV94
Copy link
Member

Is anyone working on this? If not I can do it.

Go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants