Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RV_dims and initial_values model mapping variables #6305

Closed
ricardoV94 opened this issue Nov 15, 2022 · 0 comments · Fixed by #6309
Closed

Rename RV_dims and initial_values model mapping variables #6305

ricardoV94 opened this issue Nov 15, 2022 · 0 comments · Fixed by #6309

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 15, 2022

For consistency with the changes introduced in #6281, I would rename:

  • model.initial_values to rvs_to_initial_values
  • _RV_dims to rvs_to_dims (and loose the underscore prefix, since we don't have any model function to set those?)

Having clear consistent mapping names is very helpful for model transformations such as in pymc-devs/pymc-extras#91

Eventually we might add a helper model.replace_rv that takes care of these mappings, but this issue is just about normalizing names :)

@ricardoV94 ricardoV94 changed the title Rename RV_dims and initvals Rename RV_dims and initial_values model mapping variables Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant