-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stein methods #2183
add stein methods #2183
Conversation
@@ -19,6 +19,7 @@ | |||
'ADVI', | |||
'FullRankADVI', | |||
'SVGD', | |||
'ASVGD', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's ASVGD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amortized Stein Variational Gradient Descent
Can be found here. It is a novel black box algorithm for wild inference that doesn't require q(z)
pymc3/variational/__init__.py
Outdated
|
||
from .stein import Stein | ||
from .approximations import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we removed all * imports in other parts of the code-base, shouldn't reintroduce it here. cc @ColCarroll
That's ready for review |
I assigned @taku-y if he has time. |
I think I'll add a note about behavior of sampler in high dimensions. After I see no problem for merge |
Important Note: |
Here is the log of Travis on
I'm not sure if this error rate is acceptable. |
I'm more concerned about poor ASVGD performance on simple problems. I'l increase number of iterations for these tests and lower relative tolerance |
@taku-y I've fixed tests, they look better now. (passing locally) |
ASVGD results are comparable on the BEST example and the code looks good to me. I think its ready to merge. |
Awesome! Should also add an example with short description. |
Sure, coming soon in my blog |
I'll point on the problems that can be met using asvgd. |
Excellent work all
…On 22 May 2017 10:17 pm, "Maxim Kochurov" ***@***.***> wrote:
I'll point on the problems that can be met using asvgd.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2183 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiDEt2OQlPKqJn1ww9fQFh5yLdwONks5r8ft5gaJpZM4NaE39>
.
|
More and more papers use stein methods. Here I implement convenient interface to it