-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort imports in another 9 notebooks #4074
Sort imports in another 9 notebooks #4074
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #4074 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 88 88
Lines 13860 13860
=======================================
Hits 12263 12263
Misses 1597 1597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, and well done on nbqa
@MarcoGorelli ! Will be super useful in CI 😉
Thanks! I'm very glad you're open to trying it out, I was looking for a good use-case for it and this has already helped me iron-out some bugs. Of course, if you change your mind or decide you no longer want to support this, please do let me know - after ~1 year of closely following the pandas issues/PRs trackers, I'm fully aware of how draining it can be to have to review simple PRs 🤣 |
Definitely, super use-case! And if this helps you improve nbqa at the same time, that's a win-win 😉 |
Hey @AlexAndorra - is it OK if I include this quote of yours in my README, along with a link to your podcast? |
Sure @MarcoGorelli, go ahead! |
Same story as #4073
To get these changes I did the following:
setup.cfg
:.nbqa.ini
and then ran
nbqa isort docs/source/notebooks/ --treat-comment-as-code '# %%'
EDIT for
docs/source/notebooks/GP-MeansAndCovs.ipynb
I manually put the magic line at the bottom of the cell and then rannbqa isort
againUPDATE
Current configs:
setup.cfg
:[isort] lines_between_types=1
.nbqa.ini
command to run: