Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix str representations for KroneckerNormal and MatrixNormal #4243

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

Spaak
Copy link
Member

@Spaak Spaak commented Nov 22, 2020

Fixes #4240. Additionally, updates Distribution.__str__ and PyMC3Variable.__str__ such that they fallback to the old super().__str__ in case _str_repr_ raises an error (which might happen in e.g. custom distribution subclasses without _distr_params_for_repr defined).

@Spaak Spaak changed the title Fix str representations for KroneckerNormal and MatrixNormal Fix str representations for KroneckerNormal and MatrixNormal Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #4243 (ee21a07) into master (ad63b94) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
- Coverage   88.19%   88.18%   -0.02%     
==========================================
  Files          89       89              
  Lines       14358    14371      +13     
==========================================
+ Hits        12663    12673      +10     
- Misses       1695     1698       +3     
Impacted Files Coverage Δ
pymc3/model.py 89.17% <50.00%> (-0.20%) ⬇️
pymc3/distributions/multivariate.py 81.17% <85.71%> (+0.04%) ⬆️
pymc3/distributions/distribution.py 94.47% <100.00%> (+0.04%) ⬆️

@Spaak Spaak added this to the 3.10 milestone Nov 23, 2020
@Spaak Spaak added the bug label Nov 23, 2020
@Spaak Spaak requested a review from michaelosthege November 23, 2020 15:11
@Spaak Spaak requested a review from AlexAndorra November 23, 2020 16:24
@Spaak Spaak mentioned this pull request Nov 23, 2020
4 tasks
Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Spaak ! I'll merge once tests pass 😉

@Spaak Spaak merged commit a3a63da into pymc-devs:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken str representation for Kronecker Normal distribution
3 participants