-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bart: Refactor splitting variables and predictions #4310
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #4310 +/- ##
==========================================
+ Coverage 87.56% 88.14% +0.57%
==========================================
Files 88 87 -1
Lines 14270 14361 +91
==========================================
+ Hits 12496 12658 +162
+ Misses 1774 1703 -71
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really tell what the changes are about. Please add some description of intent/purpose for this PR.
Also @aloctavodia please propose a line to be added to the README over in #4424 that mentions this PR and informs about the API change.
This add a new predict method to compute out of sample predictions evaluated at new X values. This also refactors how splitting variables are generated, this simplifies the previous code and provides a small performance improvement.