Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move BART to its own module #5058

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Conversation

aloctavodia
Copy link
Member

Solves #4884. I do not agree with the characterization of BART as a "model architecture", I think is better to think about it as an stochastic process (or at least as something that approximated that). But GPs have the same description and they are also separated in its own module. Also this separation makes sense when in the near future we (I) add some utilities to work with BART.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #5058 (3994adc) into main (70f1975) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5058   +/-   ##
=======================================
  Coverage   78.33%   78.34%           
=======================================
  Files         129      130    +1     
  Lines       24427    24430    +3     
=======================================
+ Hits        19136    19140    +4     
+ Misses       5291     5290    -1     
Impacted Files Coverage Δ
pymc/bart/bart.py 100.00% <ø> (ø)
pymc/bart/tree.py 100.00% <ø> (ø)
pymc/distributions/__init__.py 100.00% <ø> (ø)
pymc/step_methods/__init__.py 100.00% <ø> (ø)
pymc/__init__.py 96.07% <100.00%> (+0.07%) ⬆️
pymc/bart/__init__.py 100.00% <100.00%> (ø)
pymc/bart/pgbart.py 95.95% <100.00%> (ø)
pymc/sampling.py 87.43% <100.00%> (+0.01%) ⬆️
pymc/step_methods/hmc/nuts.py 95.00% <100.00%> (ø)
pymc/tests/test_bart.py 100.00% <100.00%> (ø)
... and 1 more

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure. I like it

@aloctavodia aloctavodia merged commit a3cc81c into pymc-devs:main Oct 8, 2021
@aloctavodia aloctavodia deleted the bart_module branch October 8, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants