Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has essentially the same effect as the changes proposed in #5223 but avoiding the horrible heuristic of resetting the sampler. Instead, one the particle is copied from the previous tree and the leaf values are resampled taking into account the current sum of trees. This PR also increases the number of particles but decreases the number of tress fitted per step. The overall effect is a slower sampler that we currently have but much faster than the change proposed in #5223. Still hold the observation that proposing better trees should lead to decrease the number of necessary particles while keeping the accuracy high and the sampler running smoothly. That is something I will explore in a future PR.