Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

round_to should be an optional kwarg in RegressionDiscontinuity.summary() #300

Closed
drbenvincent opened this issue Mar 4, 2024 · 0 comments
Closed

round_to should be an optional kwarg in RegressionDiscontinuity.summary() #300

drbenvincent opened this issue Mar 4, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@drbenvincent
Copy link
Collaborator

For all the other experiment classes the function signature is

def summary(self, round_to=None) -> None:

but for RegressionDiscontinuity it is

def summary(self, round_to: None) -> None:

So there is an error in this function signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drbenvincent