Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto release of CausalPy 0.2.3 to PyPI failed #315

Closed
drbenvincent opened this issue Apr 5, 2024 · 10 comments
Closed

Auto release of CausalPy 0.2.3 to PyPI failed #315

drbenvincent opened this issue Apr 5, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@drbenvincent
Copy link
Collaborator

See here https://github.com/pymc-labs/CausalPy/actions/runs/8569317167

Tagging @anevolbap, @juanitorduz, @jpreszler as I won't be able to get to this until next week 😭

@drbenvincent drbenvincent added the bug Something isn't working label Apr 5, 2024
@juanitorduz
Copy link
Collaborator

Not this weekend 🙈😞. I'll try early next week (never release or deploy on Fridays 😅)

@jpreszler
Copy link
Contributor

Based on a quick look, I think changing the download-artifact@v3 to V4 in the release yaml may fix things. The artifact is being uploaded with V4 and based on https:// github.com/actions/download-artifact there are breaking changes and mixing the two is problematic.

@anevolbap
Copy link
Contributor

Based on a quick look, I think changing the download-artifact@v3 to V4 in the release yaml may fix things. The artifact is being uploaded with V4 and based on https:// github.com/actions/download-artifact there are breaking changes and mixing the two is problematic.

Agreed. The version mismatch arises from issue #310. It could be reverted, or we could simply update the version of download-artifact to V4. I can do either of the two.

@drbenvincent
Copy link
Collaborator Author

Agreed. The version mismatch arises from issue #310. It could be reverted, or we could simply update the version of download-artifact to V4. I can do either of the two.

Happy for you to take this on. It's outside my area of expertise.

@anevolbap
Copy link
Contributor

@drbenvincent, there is an open PR (#316) that reverts the problematic changes and hopefully fixes the auto-release issues.

@drbenvincent
Copy link
Collaborator Author

@drbenvincent, there is an open PR (#316) that reverts the problematic changes and hopefully fixes the auto-release issues.

Great stuff. Thanks for the speedy response. In theory, if I merge this and manually trigger the release workflow, that should maybe upload 0.2.3 to pypi without having to do another version bump?

@anevolbap
Copy link
Contributor

@drbenvincent, there is an open PR (#316) that reverts the problematic changes and hopefully fixes the auto-release issues.

Great stuff. Thanks for the speedy response. In theory, if I merge this and manually trigger the release workflow, that should maybe upload 0.2.3 to pypi without having to do another version bump?

Yes, if I understand correctly the details of the release workflow you are correct, there is no need for an extra version bump 🤞

@drbenvincent
Copy link
Collaborator Author

Hmmm, re-ran the GitHub action, but that failed again

@anevolbap
Copy link
Contributor

anevolbap commented Apr 5, 2024

The step Build source distribution seems to still be using the older versions (e.g. checkout@v4 instead of v3), like it is cached. Is it possible to run it from scratch?

EDIT: the release is tied to the tag 0.2.3 and commit 9746996 which is previous to the last PR that reverts the bad changes (commit dbaa17b). I'm not familiar with release processes but seems a re-tagging is needed to include the last commit or simply a new tag bumping the version.

@drbenvincent
Copy link
Collaborator Author

I manually uploaded 0.2.3 to pypi. So the current version is now available to pip install :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants