Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual appearance of tables in docs #375

Closed
drbenvincent opened this issue Jun 26, 2024 · 8 comments
Closed

Improve visual appearance of tables in docs #375

drbenvincent opened this issue Jun 26, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@drbenvincent
Copy link
Collaborator

Under the new theme tables look like this
Screenshot 2024-06-26 at 13 20 12

and when the mouse hovers over a row, we get a highlight like this
Screenshot 2024-06-26 at 13 19 50

I think this is far from optimal. It would be good see what someone is capable of doing with custom css.

@drbenvincent drbenvincent added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 26, 2024
@Mark0047
Copy link

@drbenvincent can I work on this? How about making it match the CausalPy theme (blue and green) or just gray?

@drbenvincent
Copy link
Collaborator Author

drbenvincent commented Jun 26, 2024

Hi @HarisMughal. Feel free to give it a go! I think a coloured highlight makes sense. If the current one is a theme option, maybe it makes sense to change that colour site wide?

The white/grey is good as a default row colour. But the lines/space between cells is very thin at the moment.

@Mark0047
Copy link

Mark0047 commented Jul 5, 2024

For Dark Mode
image
For Light Mode with new cell spaces
image

Code
`
html[data-theme="light"]{
--pst-color-table-row-hover-bg: #83db66;
--pst-color-secondary:#83db66;
}

html[data-theme="dark"] {
--pst-color-table-row-hover-bg: #093e60;
--pst-color-secondary:#093e60;
}

.table td ~ td, .table td ~ th, .table th ~ td, .table th ~ th{
border-left-width: 1.5px;
}`

Furthermore, I believe we need to revamp the whole theme as other items (buttons, search, hover) are still following default theme I tried to change color and looks really great and makes more sense! Have a look

image
image
Shall I report a new issue for this ? @drbenvincent

@Mark0047
Copy link

Any update? @drbenvincent

@drbenvincent
Copy link
Collaborator Author

Sorry for the slow reply @Mark0047. I just want to get @OriolAbril 's opinion on editing the theme. We have a number of sites all using this theme so I want to check if specialising this one is going to cause headaches in the future?

@Mark0047
Copy link

Yes please would love to hear senior's analysis.

And shall I push the code for table?

@OriolAbril
Copy link
Contributor

To keep the theme consistent across libraries we have decided to abstract the theme configuration and then use that "custom theme", see #385.

@drbenvincent
Copy link
Collaborator Author

So now the theme is here https://github.com/pymc-labs/labs-sphinx-theme and outside of my direct control. I think it makes most sense to either leave this, or propose a change on the new labs-sphinx-theme repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants