-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visual appearance of tables in docs #375
Comments
@drbenvincent can I work on this? How about making it match the CausalPy theme (blue and green) or just gray? |
Hi @HarisMughal. Feel free to give it a go! I think a coloured highlight makes sense. If the current one is a theme option, maybe it makes sense to change that colour site wide? The white/grey is good as a default row colour. But the lines/space between cells is very thin at the moment. |
For Dark Mode Code html[data-theme="dark"] { .table td ~ td, .table td ~ th, .table th ~ td, .table th ~ th{ Furthermore, I believe we need to revamp the whole theme as other items (buttons, search, hover) are still following default theme I tried to change color and looks really great and makes more sense! Have a look
|
Any update? @drbenvincent |
Sorry for the slow reply @Mark0047. I just want to get @OriolAbril 's opinion on editing the theme. We have a number of sites all using this theme so I want to check if specialising this one is going to cause headaches in the future? |
Yes please would love to hear senior's analysis. And shall I push the code for table? |
To keep the theme consistent across libraries we have decided to abstract the theme configuration and then use that "custom theme", see #385. |
So now the theme is here https://github.com/pymc-labs/labs-sphinx-theme and outside of my direct control. I think it makes most sense to either leave this, or propose a change on the new |
Under the new theme tables look like this
and when the mouse hovers over a row, we get a highlight like this
I think this is far from optimal. It would be good see what someone is capable of doing with custom css.
The text was updated successfully, but these errors were encountered: