Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create load_from_idata ModelBuilder method #1258

Open
wd60622 opened this issue Dec 7, 2024 · 2 comments
Open

Create load_from_idata ModelBuilder method #1258

wd60622 opened this issue Dec 7, 2024 · 2 comments

Comments

@wd60622
Copy link
Contributor

wd60622 commented Dec 7, 2024

The load classmethod has a few steps:

This class method has a few steps:
- Load the InferenceData from the file.
- Construct a new instance of the model using the InferenceData attrs
- Build the model from the InferenceData
- Check if the model id matches the id in the InferenceData loaded.

This would result in separate the first from the rest which the current load classmethod would be able to depend on the new method.

Just bringing up in case someone has the InferenceData object and wants to recreate the model. This relaxes our assumption of IO.

CC: @juanitorduz

Reference: wd60622/pymc-marketing-dagster-example#2

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 9, 2024

Would also help against #1218

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 13, 2024

Hi, @JnsLns
Would this help with your issue? This route, you'd see that the model is build and is incompatible

@wd60622 wd60622 added this to the 0.11.0 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant