Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose adstock mode in functions #643

Closed
wd60622 opened this issue Apr 23, 2024 · 0 comments · Fixed by #665
Closed

Expose adstock mode in functions #643

wd60622 opened this issue Apr 23, 2024 · 0 comments · Fixed by #665
Labels
enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Apr 23, 2024

The mode parameter of the batched_convolution function isn't exposed in the subsequent adstock functions. For instance, it is hard coded.

@wd60622 wd60622 added enhancement New feature or request MMM labels Apr 23, 2024
@juanitorduz juanitorduz added the good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants