Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple coordinates, data and build model from Model Builder #788

Open
juanitorduz opened this issue Jun 27, 2024 · 0 comments
Open

Decouple coordinates, data and build model from Model Builder #788

juanitorduz opened this issue Jun 27, 2024 · 0 comments
Labels
enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children

Comments

@juanitorduz
Copy link
Collaborator

The bug in #787 was hard to catch. The problem is that in the build_model method, we are doing many things at once. We need to modularize this and add better tests.
@juanitorduz juanitorduz added enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children labels Jun 27, 2024
@juanitorduz juanitorduz mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juanitorduz