[ FEATURE ] Add support for processing and snatching multi-season releases

[duramato]

Branch/Commit: develop
OS: Ubuntu 14.04
What you did: Snatched a multi season pack ie The.Magic.School.Bus.S01-S04.DVDRip.x264-DEiMOS
What happened: Only marked the season the snatch was made from as snatched
What you expected: To mark all seasons as snatched from 1 to 4

[fernandog]

Not an issue. Its feature request: add regex for multi-season

[duramato]

It is, if you snatch S01-S02 it should mark both as snatched since thats what happened

[fernandog]

@labrys guessit detects as S01 and S04

We should think using guessit soon

[duramato]

it isnt just season 1 and 4 , its 1,2,3 and 4

[fernandog]

So guessit is wrong. Is there a multi-season ? Any docs about it?

[duramato]

S01-S04 or COMPLETE for the whole show's seasons
whats the output of guessit?

[fernandog]

guessit The.Magic.School.Bus.S01-S04.DVDRip.x264-DEiMOS
For: The.Magic.School.Bus.S01-S04.DVDRip.x264-DEiMOS
GuessIt found: {
    "title": "The Magic School Bus",
    "season": [
        1,
        4
    ],
    "format": "DVD",
    "video_codec": "h264",
    "release_group": "DEiMOS",
    "type": "episode"
}

[OmgImAlexis]

@fernandog the expected behaviour is that it matched all so I'm making it as a bug.

[fernandog]

@OmgImAlexis we never supported multi-season. Database doesnt support multi-season. We store season as INT and not LIST

[OmgImAlexis]

@fernandog can you not just loop through and set each season? E.g. if it's 1-4 then do a loop and do the same for each season?

[fernandog]

@OmgImAlexis we get information from database. not directly from file. So if database doesn't support and also regext doesnt support is not a issuen as it was never designed to support

[OmgImAlexis]

Well we shouldn't allow snatching of them then.. either we fix the issue or disallow it to be caused in the first place.

I'd honestly go with fixing it instead of just trying to prevent this "feature" from working.

[p0psicles]

Yeah, if it requires DB model and regex changed. Create a FR. And we Look at it when time is due

[OmgImAlexis]

@p0psicles we need to block them being downloaded via manual search then otherwise this should be classed as a bug.

[labrys]

@OmgImAlexis I don't think they should be blocked. Manual search is about user choice. I do agree that the incorrect snatch tho is a bug, although in my opinion it would be a low priority one. Also these kind of bugs should be given milestone tags as an indicator on when they might be fixed, e.g. when multi-season support goes live.

[OmgImAlexis]

Maybe add this to RC 2?

[p0psicles]

That depends on which changes will be required. If we need to make changes to db model, i vote not to include this. Remember we want to merge to master soon. I also expect that more issues similar to this one will rise to the surface, when we go live.

Also remember that we can't go to RC1 when issues like this are still known as bugs. All these issues should be handled with, before tagging with milestone RC1. RC is not an official milestone. It's a stage in the release process towards a certain milestone.

[ratoaq2]

As of today:

• Our parser can parse multi season correctly
• We discard multi season releases since our model (db, TVEpisode) doesn't support it.

I'm flagging this one as Feature Request since there's no bug to be fixed.

[OmgImAlexis]

Since guessit supports this can someone look into this?

For: The.Magic.School.Bus.S01-S04.DVDRip.x264-DEiMOS
GuessIt found: {
    "title": "The Magic School Bus", 
    "season": [
        1, 
        2, 
        3, 
        4
    ], 
    "format": "DVD", 
    "video_codec": "h264", 
    "release_group": "DEiMOS", 
    "type": "episode"
}

[fernandog]

DB doesnt support it.

[OmgImAlexis]

@fernandog well that'll have to be fixed then..

[fernandog]

We are waiting new DB since Nov/16.
And I bet we wont have it for 2017.
So, just wait.

[labrys]

New DB doesn't mean stop all development that relates to DB

[labrys]

Added to master feature request list - discussion for feature will continue here even though issue is closed.