{"result": "success"} page on manual search (magnifier icon)

[Naokor]

Describe the bug
When clicking the magnifier icon on a show page to launch a forced search of the episode, the result is a blank white page with {"result": "success"}

To Reproduce
Steps to reproduce the behavior:

1. Go to a show detail page
2. Click on 'the magnifier icon at the end of an episode's line'
3. See error

Expected behavior
A "success" message on the episode's line

Screenshots

Medusa (please complete the following information):
Branch: develop Commit: c304860
Version: v0.2.6 Database: 44.11
Python Version: | 2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]
SSL Version: | OpenSSL 1.0.2g 1 Mar 2016
OS: | Linux-4.12.14-041214-generic-x86_64-with-Ubuntu-16.04-xenial
Locale: | en_US.UTF-8

Additional context
Only on develop branch. Master works fine.

[sharkykh]

@OmgImAlexis
I'm not having much luck with this bug...

[p0psicles]

This is probably happening because of some other js failure. He should check chrome dev tools console.

[sharkykh]

@p0psicles
The click event handler is missing. That's not a JS error, it's all related to Vue.
It's taking over the DOM too early, I think.

[p0psicles]

Ive had the issue before. And i think it was a race condition. I dont think its vue related.

We could make sure its not following the link, when the click event hasnt been overeritten yet.

[p0psicles]

Hmm these are generated now by the app-link.
Still remember to have seen this issue before they where changed to app-link.

[sharkykh]

You're talking about the links in the snatchSelection and the recommended shows pages. Because it was loading part of the page using jQuery, and Vue can't render new components on the fly.
It's a different issue.

[p0psicles]

I think we could easily fix this, by adding a property to the app-link component, to remove the click handler.

[p0psicles]

No, i'm talking about the links in displayShow. The app-link is generating an with an href. Then ajax-ep-search.js goes over all the .epSearch and .epManualSearch classes, and binds new click handlers.

If you click the icon before the new events have been bind, your just following the link. Which is returning the json.

[OmgImAlexis]

ajax-ep-search.js there is your issue. Move the button to a new component that handles manual search instead of using an app-link since it's not a link.

[sharkykh]

Fixed with #4751.