Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFO Export - TVMaze Indexer - Show ID #9743

Closed
bzzbrr opened this issue Jul 22, 2021 · 6 comments
Closed

NFO Export - TVMaze Indexer - Show ID #9743

bzzbrr opened this issue Jul 22, 2021 · 6 comments

Comments

@bzzbrr
Copy link

bzzbrr commented Jul 22, 2021

Hello,

When exporting NFOs, medusa populates both the uniqueid and id fields with the id from the chosen indexer for a given show. However, since multiple indexers can be used, the id field alone is not meaningful. Some other software interprets the id field for a TV show as a TVDB id by default, so when a different indexer is used the metadata is interpreted incorrectly.

As far as I can tell, the ID field is deprecated in favor of the unique ID field for this reason, for example on the Kodi wiki.

The relevant code is in metadata/kodi_12plus.py, line 149.

Would it be possible to either not include the id field in the NFO, only include it when TVDB is the indexer, or make it configurable?

Thanks for the great software.

@p0psicles
Copy link
Contributor

i'll implement the uniqueid's in the next release.
example of how it will look:

<tvshow>
  <title>Space Force</title>
  <year>2020</year>
  <plot>On June 18, 2018 the federal government announced the creation of a 6th major division of the United States Armed Forces. The Goal of the new branch is "to defend satellites from attack" and "perform other space-related tasks." Or something. This is the story of the men and women who have to figure it out.</plot>
  <episodeguide>
    <url cache="auth.json" post="yes">https://api.thetvdb.com/login?{"apikey":"asdf","id":368667}|Content-Type=application/json</url>
  </episodeguide>
  <mpaa>TV-MA</mpaa>
  <uniqueid default="true" type="tvdb">368667</uniqueid>
  <uniqueid default="false" type="tmdb">85922</uniqueid>
  <uniqueid default="false" type="imdb">tt9612516</uniqueid>
  <uniqueid default="false" type="tvmaze">40445</uniqueid>
  <genre>Comedy</genre>
  <country>United States</country>
  <premiered>2020-05-29</premiered>
  <studio>Netflix</studio>
  <actor>
    <name>Steve Carell</name>
    <role>Mark R. Naird</role>
    <thumb>https://www.thetvdb.com/banners/person/296970/5ebc05b4a0e81.jpg</thumb>
  </actor>
  <actor>
    <name>John Malkovich</name>
    <role>Adrian Mallory</role>
    <thumb>https://www.thetvdb.com/banners/person/300400/5ebc0644c7253.jpg</thumb>
  </actor>
  <actor>
    <name>Tawny Newsome</name>
    <role>Angela Ali</role>
    <thumb>https://www.thetvdb.com/banners/person/505880/5ebc0677959a1.jpg</thumb>
  </actor>
  <actor>
    <name>Jimmy O. Yang</name>
    <role>Chan Kaifang</role>
    <thumb>https://www.thetvdb.com/banners/person/514361/5ebb1a2354368.jpg</thumb>
  </actor>
  <actor>
    <name>Ben Schwartz</name>
    <role>F. Tony Scarapiducci</role>
    <thumb>https://www.thetvdb.com/banners/person/285161/5ebc061e93933.jpg</thumb>
  </actor>
  <actor>
    <name>Diana Silvers</name>
    <role>Erin Naird</role>
    <thumb>https://www.thetvdb.com/banners/person/542843/5ebc059ec6789.jpg</thumb>
  </actor>
</tvshow>

@p0psicles
Copy link
Contributor

@bzzbrr do you have any idea on how to use the episodeguide tag with indexers like tvmaze and tmdb? As for now, we only pass the tvdb's url.

@p0psicles
Copy link
Contributor

implement in #9745

@bzzbrr
Copy link
Author

bzzbrr commented Jul 23, 2021

@bzzbrr do you have any idea on how to use the episodeguide tag with indexers like tvmaze and tmdb? As for now, we only pass the tvdb's url.

I do not, sorry. Some research suggests that sonarr removed the tag entirely since it was buggy and dependent on APIs that are constantly in flux.

I greatly appreciate making the change so quickly. Lastly, I noticed that the kodi legacy export uses the kodi 12+ code for setting ID. Personally I think an ID with no indexer type has no value, so this is fine, but it could break someone's workflow if they only use TVDB with some software that doesn't support uniqueid.

Thanks again!

@bzzbrr
Copy link
Author

bzzbrr commented Jul 24, 2021

Am I crazy, or do you need to both delete the existing NFOs and force a full show update in order to generate new NFOs? Without deleting, I see updated file access, but the <id> tag remains and it's missing the 3 new <uniqueid> tags.

@p0psicles
Copy link
Contributor

Yeah have to delete it

@bzzbrr bzzbrr closed this as completed Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants