Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --keep-going option to the pyodide build CLI #20

Open
agriyakhetarpal opened this issue Aug 19, 2024 · 5 comments
Open

Add a --keep-going option to the pyodide build CLI #20

agriyakhetarpal opened this issue Aug 19, 2024 · 5 comments

Comments

@agriyakhetarpal
Copy link
Member

Description

This issue proposes the addition of a --keep-going option to enable building recipes until completion and listing failed recipes at the end of the build procedure – this is so that the procedure doesn't come to a halt once one recipe fails to build.

Motivation

This came about in pyodide/pyodide#4925 when updating quite a few recipes at once

@agriyakhetarpal
Copy link
Member Author

I should be able to take a look at this myself in a while – and also come back to my other open PR :)

@hoodmane
Copy link
Member

I made an attempt at this a while back. See also
pyodide/pyodide#3249
pyodide/pyodide#4491

@ryanking13
Copy link
Member

Yes, it would be useful to have such flag. It won't be useful for non-maintainers so I am +1 for adding it as an hidden flag.

@hoodmane
Copy link
Member

Personally I would prefer not to hide it. I think maintainers are the heaviest users of the CLI and it is annoying to have to grep the codebase. Others can either use it or not. The description will be simple enough.

@ryanking13
Copy link
Member

Sure, that's fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants