Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent object paths between host and target when unpickling #53

Open
rth opened this issue Oct 24, 2022 · 1 comment
Open

More consistent object paths between host and target when unpickling #53

rth opened this issue Oct 24, 2022 · 1 comment

Comments

@rth
Copy link
Member

rth commented Oct 24, 2022

In pyodide/pyodide#3202 (comment) @hoodmane raised a good question,

How about changing pytest_pyodide to monkey patch JsException? I think this
change looks weird. If we're going to have a class with the same name both
inside and outside selenium, it should have the same path.

following #44 by @koenvo

Maybe more generally we could just install pyodide-py on the host, that way all those paths would already exist and we don't need to redefine or monkeypatch anything? I just uploaded it to PyPI, still need to automate the release.

This would be more general and should allow unpickling of other objects defined in this package if necessary.

The difficulty there is to make sure we install the pyodide-py version that matches the version of Pyodide used.

@koenvo
Copy link
Contributor

koenvo commented Nov 2, 2022

Totally agree with @hoodmane! This would also remove the need for the find_class in Unpickler.

I believe the "versions should match" argument applies to all packages installed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants