-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PyO3 #134
Comments
@thedrow Is there anything programming language-specific that you've encountered in |
pyo3-pack does not use setup.py. |
Then how do you make a PyPI compatible source package? |
Hm. Interesting! Pip already has the ability to use different build systems (PEP 517), using Otherwise, maybe there's a way we can add an option to change the build command. Something like |
Let's keep this open until PyO3/maturin#2 is resolved then or close this issue if it's not something you're willing to provide a workaround for right now. There's actually something else we need: a rust compiler. |
Right now source distributions are not supported. |
I've been using both pyo3 and cibuildwheel together to upload wheels for a little toy project for several months now. It works well you can see the travis setup here: https://github.com/mtreinish/retworkx/blob/master/.travis.yml#L35 but I used setuptools-rust because personally I found it an easier model to use than pyo3-pack. The only tricky bit is that you have to install rust nightly as a before build command. Not hard to do though. |
Looks like this is fixed via PEP517 support in pyo3-pack, and setuptools-rust is an alternative. |
For whomever else that's interested, here's the |
PyO3 is a Rust library that allows you to write Cpython extensions in Rust.
It'd be awesome to have an integration between it and https://github.com/PyO3/pyo3-pack
The text was updated successfully, but these errors were encountered: