-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build specific environment variables from the test environment #1863
Comments
While |
Maybe we should adapt them all then ? If we're thinking that we might break some edge case that requires building from sources by removing any of those environment variable then IMHO we should update them all:
|
I think removing these variables for the test step makes sense in general. Probably the right approach would be to start again from cibuildwheel/cibuildwheel/macos.py Line 675 in 7c3b0fb
And equivalents for the other platforms.
I don't follow this - normally on a user's machine |
Description
macOS builds are using multiple environment variables specific to the build environment:
MACOSX_DEPLOYMENT_TARGET
,_PYTHON_HOST_PLATFORM
,ARCHFLAGS
,SDKROOT
Those are propagated to the test environments. They should probably be removed from those.
see #1856 (comment) and the 2 following comments for more context.
Build log
No response
CI config
No response
The text was updated successfully, but these errors were encountered: