Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Parse valid PyPy links from versions.json and always build PyPy with manylinux2010+ #488

Closed
mattip opened this issue Dec 20, 2020 · 3 comments

Comments

@mattip
Copy link
Contributor

mattip commented Dec 20, 2020

Two ideas to make the PyPy experience nicer:

@Czaki
Copy link
Contributor

Czaki commented Dec 20, 2020

But the idea of cibuildwheel is to pin the build process to a specified version to get reproducibility. Or you think about an update script?

@YannickJadoul
Copy link
Member

@Czaki makes a good point here. Also, we try to have the same version for all OSes, and we do always need a new manylinux image, for each release.

I agree it would be nice, though, if something can be automated here! But we'd need to find a balance between ease of use and reproducibility (cfr. #239 & #256).

  • Never use manylinux1 for linux wheels on PyPy, since it is not supported.

I believe we already don't do this. We only have a manylinux2010 in pinned_docker_images.cfg:
https://github.com/joerick/cibuildwheel/blob/d83daa3958a9809f0b03fe125ce28d1f52ab7f14/cibuildwheel/resources/pinned_docker_images.cfg#L11-L12

Users can overwrite this by setting the CIBW_MANYLINUX_PYPY_X86_64_IMAGE environment variable, though, but only setting it to manylinux2010 (or leaving it empty) will result in cibuildwheel using an official PyPy image.

@henryiii
Copy link
Contributor

I think this is resolved as of #496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants