Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS universal2 wheel fusion? #705

Open
henryiii opened this issue May 28, 2021 · 6 comments
Open

Support macOS universal2 wheel fusion? #705

henryiii opened this issue May 28, 2021 · 6 comments

Comments

@henryiii
Copy link
Contributor

henryiii commented May 28, 2021

In the future, would it make sense to support macOS universal2 wheel fusion, like multibuild does? Either automatically when all three arches are chosen, for example? Or maybe just provide an example how how to do it if you have the two dedicated wheels?

@mayeut
Copy link
Member

mayeut commented May 29, 2021

I'm +1 on this, that was one workflow that made sense to me #473 (comment)
From the link you provided to multibuild, seems delocate already support this which is good news (I didn't check back in December that it was the case).

@mattip
Copy link
Contributor

mattip commented Nov 5, 2021

FWIW, multibuild is backtracking and will also create thin wheels. A problem was discovered with universal2 and NPY_SIZEOF_LONGDOUBLE and NPY_SIZEOF_COMPLEX_LONGDOUBLE for numpy, which was fixed in numpy/numpy#20270, but the problem may appear in other projects so it is safer to distribute separate wheels.

@isuruf
Copy link

isuruf commented Nov 5, 2021

FWIW, multibuild is backtracking and will also create thin wheels.

Not true. multibuild has always created thin wheels and did wheel fusion.

@henryiii
Copy link
Contributor Author

henryiii commented Nov 6, 2021

Yes, this is not related. NumPy is just shipping the thin wheels now. This issue is about wheel fusion, that is, making the thin wheels and then post processing them into a universal wheel, specifically making sure it's easy to do that combination step.

@mattip
Copy link
Contributor

mattip commented Mar 16, 2022

As I commented elsewhere I don't really see the need for cibuildwheel to provide this option. I haven't heard a clear need for pip install <universal2wheel>, and for app packagers I think the correct place to fuse wheels is when creating the application. Please correct me if I am mistaken.

@mattip
Copy link
Contributor

mattip commented Mar 21, 2022

xref numpy/numpy#20787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants