Wheel file ValueError not thrown when plugin enabled — is this intended?

[damonlynch]

Hi Olek,

This error is very helpfully displayed when no plugins are enabled and the pyproject.toml build options are incorrect:

ValueError: Unable to determine which files to ship inside the wheel using the following heuristics: https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection

However, when plugins are enabled (well, probably those that create an artifact, I suppose), the message is not displayed. Is this what you intend?

I ask because it took me a few hours to understand why in one of my projects was not installing. Only when I decided to "go back to basics" and pare down the pyproject.toml options by cutting out plugins did the error become apparent.

There might be important reasons for not displaying this message when plugins are used, perhaps? I don't know. But it would be nice if there were a way to still inform the developer that they probably need to fix their project's build options.

Damon

[ofek]

The message should appear in all cases and if it doesn't I'm assuming the plugin defines options (which is all that message cares about) that simply don't match anything. Can you give a reproducible example?

[damonlynch]

I don't know if it is helpful, but with this project (git main branch), and this plugin, if the sdist and wheel build targets are not specified, no ValueError is thrown.

Or to put the same thing another way, if the following is removed from this pyproject.toml, the project builds without the ValueError:

[tool.hatch.build.targets.sdist]
packages = ["src/showinfm"]

[tool.hatch.build.targets.wheel]
packages = ["src/showinfm"]